Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] class 상세 내 탭 뷰 구현 #82

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

[Feat] class 상세 내 탭 뷰 구현 #82

wants to merge 17 commits into from
+390 −2

Conversation

hansoojeongsj
Copy link
Collaborator

@hansoojeongsj hansoojeongsj commented Jan 15, 2025 •
edited
Loading

📌 Related Issues

✅ 체크 리스트

  • PR 제목의 형식을 잘 작성했나요? e.g. [Feat] PR 템플릿 작성
  • 빌드가 성공했나요? (pnpm build)
  • 컨벤션을 지켰나요?
  • 이슈는 등록했나요?
  • 리뷰어와 라벨을 지정했나요?

📄 Tasks

클래스 상세 페이지 내 탭 뷰 퍼블리싱
아이콘은 icClose로 대체했습니다.

⭐ PR Point (To Reviewer)

  • 줄바꿈
  • 날짜..?

📷 Screenshot

스크린샷 2025-01-16 061729
스크린샷 2025-01-16 061738
스크린샷 2025-01-16 061744
스크린샷 2025-01-16 061749

🔔 ETC

새롭게 알게 된 내용 !!
package.json에 scripts에
"dev": "vite--host",
-> 핸드폰에서 확인 가능

@hansoojeongsj
feat: 클래스 상세 Tab 구현 초기 (#52)
21d2d96
@hansoojeongsj
Merge branch 'develop' into feat/#52/class
ca5484e
@hansoojeongsj
feat: 위치탭 카드 내부 gap 잡는중 (#52)
08e0ca8
@hansoojeongsj
Merge branch 'develop' into feat/#52/class
58ee383
@hansoojeongsj
feat: TabList아래 구분선 추가
e8c234a
@hansoojeongsj
feat: class 상세 탭 중 소개 구현 중 (#52)
bacfdaf
@hansoojeongsj
feat: text 공컴 사용해보기 (#52)
21b4c06
@hansoojeongsj
Merge branch 'develop' into feat/#52/class
dea1dad
@hansoojeongsj
feat: 난이도 탭 기능 (#52)
57d4a74
@hansoojeongsj
feat: class 상세 탭 세부 구조 잡는 중 (#52)
82390fa
@hansoojeongsj
Merge branch 'develop' into feat/#52/class
e86a017
@hansoojeongsj
Merge branch 'develop' into feat/#52/class
e5b25ba
@hansoojeongsj
feat: Flex 컴포넌트로 변경 (#52)
421d47a
@hansoojeongsj
feat: 클래스 상세 탭 뷰 (#52)
ee559fe
@hansoojeongsj
feat: 클래스 상세 탭 뷰 폴더 위치, 이름 변경 (#52)
0b86049
@hansoojeongsj
feat: 버튼 태그 추가 (#52)
fc969f0
@hansoojeongsj hansoojeongsj added 🛠️ Feature 기능 개발 수정 첫 사랑니 labels Jan 15, 2025
@hansoojeongsj hansoojeongsj self-assigned this Jan 15, 2025
@hansoojeongsj hansoojeongsj linked an issue Jan 15, 2025 that may be closed by this pull request
[Feat] Class 상세 중 Tab 퍼블리싱 #52
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KIMGEONHWI KIMGEONHWI Awaiting requested review from KIMGEONHWI

@heesunee heesunee Awaiting requested review from heesunee

@rtttr1 rtttr1 Awaiting requested review from rtttr1

@constantly-dev constantly-dev Awaiting requested review from constantly-dev

Assignees

@hansoojeongsj hansoojeongsj

Labels
수정 첫 사랑니 🛠️ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] Class 상세 중 Tab 퍼블리싱
1 participant
@hansoojeongsj