Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat/#36] PlaceDetailImageLazyRow UI 컴포넌트 구현 #37

Merged
merged 6 commits into from
Jan 16, 2025
Merged

[Feat/#36] PlaceDetailImageLazyRow UI 컴포넌트 구현 #37

merged 6 commits into from
Jan 16, 2025

Conversation

Roel4990
Copy link
Member

Related issue 🛠

Work Description ✏️

  • PlaceDetailImageLazyRow UI 컴포넌트 구현

Screenshot 📸

image image image image

To Reviewers 📢

@Roel4990 Roel4990 added 🧡세홍🧡 🧡세홍🧡 FEAT✨ 새로운 기능 구현 labels Jan 15, 2025
@Roel4990 Roel4990 self-assigned this Jan 15, 2025
@Roel4990 Roel4990 requested a review from a team as a code owner January 15, 2025 14:42
@Roel4990 Roel4990 linked an issue Jan 15, 2025 that may be closed by this pull request
[FEAT] 장소 상세 페이지 PlaceDetailImageLazyRow UI 컴포넌트 구현 #36
Closed
1 task
chattymin
chattymin requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
수정하시고 노티 부탁드립니다~!

...rc/main/java/com/spoony/spoony/presentation/placeDetail/component/PlaceDetailImageLazyRow.kt Outdated

@Composable
fun PlaceDetailImageLazyRow(
imageList: List<String>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2) ImmutableList 부탁드립니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다!

...rc/main/java/com/spoony/spoony/presentation/placeDetail/component/PlaceDetailImageLazyRow.kt Outdated
horizontalArrangement = Arrangement.spacedBy(10.dp),
contentPadding = PaddingValues(horizontal = 20.dp)
) {
items(imageList) { imageUrl ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1) key 사용해 주세요.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정완료했습니다!

...rc/main/java/com/spoony/spoony/presentation/placeDetail/component/PlaceDetailImageLazyRow.kt
}
}

@Preview
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5) preview에서는 어차피 coil 이미지가 안보입니다.
url 붙여넣기 하기 귀찮으실텐데 empty로 넣으셔도 똑같을거에요

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3) isBlurred가 true인 경우도 추가해주세요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다!

@Roel4990 Roel4990 requested a review from chattymin January 15, 2025 17:30
chattymin
chattymin approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 🚀

Hyobeen-Park
Hyobeen-Park approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

캬~ 수고하셨습니다 🚀

angryPodo
angryPodo approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@angryPodo angryPodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 달게 없네요ㅎㅎ 고생하셨습니다!

@Roel4990 Roel4990 merged commit 46eae27 into develop Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angryPodo angryPodo angryPodo approved these changes

@Hyobeen-Park Hyobeen-Park Hyobeen-Park approved these changes

@chattymin chattymin chattymin approved these changes

Assignees

@Roel4990 Roel4990

Labels
FEAT✨ 새로운 기능 구현 🧡세홍🧡 🧡세홍🧡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 장소 상세 페이지 PlaceDetailImageLazyRow UI 컴포넌트 구현
4 participants
@Roel4990 @chattymin @Hyobeen-Park @angryPodo