Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ambiguity of Date.date offset larger than 24hours #28

Open
eldesh opened this issue Jun 15, 2020 · 0 comments
Open

ambiguity of Date.date offset larger than 24hours #28

eldesh opened this issue Jun 15, 2020 · 0 comments

Comments

@eldesh
Copy link

eldesh commented Jun 15, 2020

Sorry, this is a bug report, not an extension proposal.
I couldn't find a place to report a bug of basis spec.

Basis Date sais that:

Offsets are taken modulo 24 hours. That is, we express t, in hours, as sgn(t)(24*d + r), where d and r are non-negative, d is integral, and r < 24. The offset then becomes sgn(t)r and sgn(t)(24d) is added to the hours (before converting hours to days).

But sml/nj 110.97 takes an offset >24, ignore it:

- Date.toString (Date.date { year=2000, day= 1, hour=0, minute=0, month=Date.Jan, offset=SOME (Time.fromSeconds (0)), second=0});
val it = "Sat Jan 01 00:00:00 2000" : string
- Date.toString (Date.date { year=2000, day= 1, hour=0, minute=0, month=Date.Jan, offset=SOME (Time.fromSeconds (3600 * 24 + 1)), second=0});
val it = "Sat Jan 01 00:00:01 2000" : string

I think this implementation is correct, because offset larger than 24 is unnatural.
Also, the spec sais taken modulo 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant