Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all entities used for tests in the entities folder #689

Closed
francescalb opened this issue Nov 1, 2023 · 0 comments · Fixed by #731
Closed

Move all entities used for tests in the entities folder #689

francescalb opened this issue Nov 1, 2023 · 0 comments · Fixed by #731

Comments

@francescalb
Copy link
Collaborator

francescalb commented Nov 1, 2023 •
edited
Loading

There are both entities in the folder:
https://github.com/SINTEF/dlite/tree/master/bindings/python/tests

and in the folder
https://github.com/SINTEF/dlite/tree/master/bindings/python/tests/entities

Similarly entities, both valid and invalid are found here:
https://github.com/SINTEF/dlite/tree/master/bindings/python/tests/input

It is easier to find them again if they are all in the same place for the tests.

Concurrently a folder at the same level should be made for entities and entities moved there.
@francescalb francescalb added good first issue Good for newcomers and removed good first issue Good for newcomers labels Nov 1, 2023
@jesper-friis jesper-friis mentioned this issue Dec 2, 2023
Merged
9 tasks
@jesper-friis jesper-friis linked a pull request Dec 2, 2023 that will close this issue
Move test entities and input and output files to sub-directories #731
Merged
9 tasks
jesper-friis added a commit that referenced this issue Jan 24, 2024
@jesper-friis
Move test entities and input and output files to sub-directories (#731)
ece8707 
# Description
Moved entities, input and output files to respectively sub-directories
in the Python tests.

Closes #689 
Addresses also issue #609 

While updating the tests to use the new sub-directories, a few other
path-related issues were discovered and fixed:
* two potential segfaults in dlite-storage.i and dlite.rdf.c if an
invalid path is provided were fixed
* raise DLiteParseError instead of DLiteOtherError for invalid json
input
* allow to hide DLiteOtherError by using DLiteUnknownError.


## Type of change
- [x] Bug fix & code cleanup
- [ ] New feature
- [ ] Documentation update
- [ ] Test update

## Checklist for the reviewer
This checklist should be used as a help for the reviewer.

- [ ] Is the change limited to one issue?
- [ ] Does this PR close the issue?
- [ ] Is the code easy to read and understand?
- [ ] Do all new feature have an accompanying new test?
- [ ] Has the documentation been updated as necessary?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move test entities and input and output files to sub-directories SINTEF/dlite
1 participant
@francescalb