Do's and Don'ts.md

Do's and Don'ts

General Types

Number, String, Boolean, and Object

Don't ever use the types Number, String, Boolean, or Object. These types refer to non-primitive boxed objects that are almost never used appropriately in JavaScript code.

/* WRONG */
function reverse(s: String): String;

Do use the types number, string, and boolean.

/* OK */
function reverse(s: string): string;

If you're tempted to use the type Object, consider using any instead. There is currently no way in TypeScript to specify an object that is "not a primitive".

Generics

Don't ever have a generic type which doesn't use its type parameter. TODO: Link to FAQ

TODO: More

Callback Types

Return Types of Callbacks

Don't use the return type any for callbacks whose value will be ignored:

/* WRONG */
function fn(x: () => any) {
	x();
}

Do use the return type void for callbacks whose value will be ignored:

/* OK */
function fn(x: () => void) {
	x();
}

Why: Using void is safer because it prevents you from accidently using the return value of x in an unchecked way:

function fn(x: () => void) {
	var k = x(); // oops! meant to do something else
	k.doSomething(); // error, but would be OK if the return type had been 'any'
}

Optional Parameters in Callbacks

Don't use optional parameters in callbacks unless you really mean it:

/* WRONG */
interface Fetcher {
	getObject(done: (data: any, elapsedTime?: number) => void): void;
}

This has a very specific meaning: the done callback might be invoked with 1 argument or might be invoked with 2 arguments. The author probably intended to say that the callback might not care about the elapsedTime parameter, but there's no need to make the parameter optional to accomplish this -- it's always legal to provide a callback that accepts fewer arguments.

Do write callback parameters as non-optional:

/* OK */
interface Fetcher {
	getObject(done: (data: any, elapsedTime: number) => void): void;
}

Overloads and Callbacks

Don't write separate overloads that differ only on callback arity:

/* WRONG */
declare function beforeAll(action: () => void, timeout?: number): void;
declare function beforeAll(action: (done: DoneFn) => void, timeout?: number): void;

Do write a single overload using the maximum arity:

/* OK */
declare function beforeAll(action: (done: DoneFn) => void, timeout?: number): void;

Why: It's always legal for a callback to disregard a parameter, so there's no need for the shorter overload. Providing a shorter callback first allows incorrectly-typed functions to be passed in because they match the first overload.

Function Overloads

Ordering

Don't put more general overloads before more specific overloads:

/* WRONG */
declare function fn(x: any): any;
declare function fn(x: HTMLElement): number;
declare function fn(x: HTMLDivElement): string;

var myElem: HTMLDivElement;
var x = fn(myElem); // x: any, wat?

Do sort overloads by putting the more general signatures after more specific signatures:

/* OK */
declare function fn(x: HTMLDivElement): string;
declare function fn(x: HTMLElement): number;
declare function fn(x: any): any;

var myElem: HTMLDivElement;
var x = fn(myElem); // x: string, :)

Why: TypeScript chooses the first matching overload when resolving function calls. When an earlier overload is "more general" than a later one, the later one is effectively hidden and cannot be called.

Use Optional Parameters

Don't write several overloads that differ only in trailing parameters:

/* WRONG */
interface Moment {
    diff(b: MomentComparable): number;
    diff(b: MomentComparable, unitOfTime: string): number;
    diff(b: MomentComparable, unitOfTime: string, round: boolean): number;
}

Do use optional parameters whenever possible:

/* OK */
interface Moment {
    diff(b: MomentComparable, unitOfTime?: string, round?: boolean): number;
}

Note that this collapsing should only occur when all overloads have the same return type.

Why: This is important for two reasons.

TypeScript resolves signature compatibility by seeing if any signature of the target can be invoked with the arguments of the source, and extraneuous arguments are allowed. This code, for example, exposes a bug only when the signature is correctly written using optional parameters:

function fn(x: (a: string, b: number, c: number) => void) { }
var x: Moment;
// When written with overloads, OK -- used first overload
// When written with optionals, correctly an error
fn(x.diff);

The second reason is when a consumer uses the "strict null checking" feature of TypeScript. Because unspecified parameters appear as undefined in JavaScript, it's usually fine to pass an explicit undefined to a function with optional arguments. This code, for example, should be OK under strict nulls:

var x: Moment;
// When written with overloads, incorrectly an error because of passing 'undefined' to 'string' 
// When written with optionals, correctly OK
x.diff(something, someOtherThing ? undefined : "hour");

Use Union Types

Don't write overloads that differ by type in only one argument position:

/* WRONG */
interface Moment {
    utcOffset(): number;
    utcOffset(b: number): Moment;
    utcOffset(b: string): Moment;
}

Do use union types whenver possible:

/* OK */
interface Moment {
    utcOffset(): number;
    utcOffset(b: number|string): Moment;
}

Note that we didn't make b optional here because the return types of the signatures differ.

Why: This is important for people who are "passing through" a value to your function:

function fn(x: string): void;
function fn(x: number): void;
function fn(x: number|string) {
	// When written with separate overloads, incorrectly an error
	// When written with union types, correctly OK
	return moment().utcOffset(x);
}