Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port blake2 on coresimd #56

Open
newpavlov opened this issue Jun 21, 2018 · 12 comments
Open

Port blake2 on coresimd #56

newpavlov opened this issue Jun 21, 2018 · 12 comments

Comments

@newpavlov
Copy link
Member

With stabilization of SIMD intrinsics in Rust 1.27 we can remove simd feature from the blake2 crate.

@tomtau
Copy link

tomtau commented Jan 17, 2019

btw, here's a bounty on this issue: https://www.bountysource.com/issues/59948303-port-blake2-on-coresimd

@kazcw
Copy link
Contributor

kazcw commented Jan 24, 2019

How would this work for rustc 1.21..=1.26?

@newpavlov
Copy link
Member Author

For v0.8 it will have to be feature-gated behind some feature (it can be the same simd feature), but I am thinking about migrating to Rust 2018 for v0.9.

@DonaldTsang
Copy link

What about BLAKE3?

@tarcieri
Copy link
Member

I’d be very much into us having a high-performance BLAKE3 implementation but am not aware of the state-of-the-art in Rust BLAKE3 libraries /cc @zooko

@tarcieri
Copy link
Member

See BLAKE3 #103

@pczarn
Copy link

pczarn commented Jan 16, 2023

I started working on the issue.

@tarcieri
Copy link
Member

@pczarn it'd be really good to get #228 landed before we try to extend the current implementation

@pczarn
Copy link

pczarn commented Jan 17, 2023

@tarcieri Okay, so you are close to getting a new implementation, but a migration from core::arch x86/x86_64 intrinsics to a portable core::simd will remain to be done?

@pczarn
Copy link

pczarn commented Jan 17, 2023

Looks like coresimd is some internal utility, and not core::simd, so:

  • could you point me to the code for coresimd?
  • would it be better to give it a name that cannot be confused with core's simd?
  • are you looking into using core's simd once it gets stabilized?

@tarcieri
Copy link
Member

I think this ticket is actually referring to core::arch SIMD intrinsics, though adding support for core::simd would be nice

@pczarn
Copy link

pczarn commented Jan 18, 2023

Ok, please update me when progress with #228 happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants