Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rfc2985 and rfc7292 to const-oid db for pkcs#9 and pkcs#12 #1543

Closed
juliusl opened this issue Oct 4, 2024 · 4 comments · Fixed by #1568
Closed

Add rfc2985 and rfc7292 to const-oid db for pkcs#9 and pkcs#12 #1543

juliusl opened this issue Oct 4, 2024 · 4 comments · Fixed by #1568
Labels
good first issue Good for newcomers

Comments

@juliusl
Copy link

juliusl commented Oct 4, 2024

It would be nice to add rfc2985 and rfc7292 which reference some common attributes such as "friendlyName" and "localKeyId" both of which are common pkcs#12 attributes.

@tarcieri
Copy link
Member

tarcieri commented Oct 8, 2024

They should be pretty easy to add. See #1547 for a recent example

@baloo baloo added the good first issue Good for newcomers label Oct 9, 2024
@nemynm
Copy link
Contributor

nemynm commented Oct 10, 2024

I can send something by the end of the week probably, if no one else is on it. Would you want one or two PRs?

@tarcieri
Copy link
Member

It's fine to put them both in one

@nemynm
Copy link
Contributor

nemynm commented Oct 10, 2024

I actually think rfc2985 is already present since #1248. I'll just add rfc7292 then. Unless I missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants