Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Build fails after update to react-native 0.75.x and react-native-windows 0.75,x #382

Open
JakobKrummeichAndrena opened this issue Sep 13, 2024 · 10 comments

Comments

@JakobKrummeichAndrena
Copy link

JakobKrummeichAndrena commented Sep 13, 2024

For react-native version 0.75.x and react-native-windows version 0.75.x this library does not compile anymore on windows. There are two issues: the TargetPlatformMinVersion is too low and there is an error when compiling the sources.

The error is

× Build failed with message C:\blobutiltestproject\node_modules\react-native\ReactCommon\react\bridging\Convert.h(81,1): error C2938: 'std::enable_if_t<false,int>' : Failed to specialize alias template (compiling source file C:\blobutiltestproject\node_modules\react-native-windows\Microsoft.ReactNative.Cxx\TurboModuleProvider.cpp) [C:\blobutiltestproject\node_modules\react-native-blob-util\windows\ReactNativeBlobUtil\ReactNativeBlobUtil.vcxproj]. Check your build configuration.
Command failed. Re-run the command with --logging for more information.

Steps to reproduce:

  1. npx --yes @react-native-community/cli@next init blobutiltestproject --version "latest"
  2. cd blobutiltestproject
  3. yarn add react-native-windows@^0.75.0
  4. npx react-native init-windows --overwrite
  5. yarn add react-native-blob-util
  6. change WindowsTargetPlatformMinVersion in node_modules/react-nativve-blob-util/windows/ReactNativeBlobUtil/ReactNativeBlobUtil.vcxproj to 10.0.17763.0
  7. yarn windows
  8. get the error messge mentioned above

Package versions (resolutions):
react-native: 0.75.3
react-native-windows: 0.75,0
react-native-blob-util: 0.19.11

OS Version: Windows 10
Visual Studio: Visual Studio Community 2022, Version 17.11.35303.130

To summarize, there are two issues:

  1. WindowsTargetPlatformMinVersion needs to be increased
  2. Windows project does not compile (I don't know how to fix it)
@raphpay
Copy link

raphpay commented Sep 23, 2024

Same here

@JakobKrummeichAndrena
Copy link
Author

@RonRadtke do we have any updates on this? :)

@raphpay
Copy link

raphpay commented Oct 16, 2024

@RonRadtke do we have any updates on this? :)

None for now 🤷🏼‍♂️

@JakobKrummeichAndrena
Copy link
Author

@RonRadtke do we have any updates on this?

@surajkhanal
Copy link

Facing the same issue

@JakobKrummeichAndrena
Copy link
Author

We were now forced to replace react-native-blob-util with this one: https://github.com/birdofpreyru/react-native-fs

@RonRadtke
Copy link
Owner

If anyone has a fix for it - would be great.
Will take a while till I have the time to set up and look into it since it requires the windows setup

@JakobKrummeichAndrena
Copy link
Author

Ok thanks for the reply! Unfortunately, the windows setup is really annoying. Now that we found a different solution we are of course much less inclined to work out a solution ourselves.

@RonRadtke
Copy link
Owner

Ok thanks for the reply! Unfortunately, the windows setup is really annoying. Now that we found a different solution we are of course much less inclined to work out a solution ourselves.

Of course - I can understand that very much. Still would be great though, but I can understand that you switch and don't want to invest in this lib then, no worries :)

@cjhines
Copy link

cjhines commented Nov 15, 2024

Can someone confirm that the following patch also works for them?

If so, I'll make a PR :)

react-native-blob-util+0.19.11.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants