Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rabin-Karp clarity #312

Open
luciankt opened this issue Nov 8, 2023 · 0 comments
Open

Rabin-Karp clarity #312

luciankt opened this issue Nov 8, 2023 · 0 comments
Labels
visual-impurity Something looks off or unaesthetic

Comments

@luciankt
Copy link
Collaborator

luciankt commented Nov 8, 2023

A couple of confusing points on Rabin Karp that have been brought up:

  • The i <= n - m check is different than the reference because i is incremented before the hash is rolled instead of after.
  • The hash rolling line where it says from i to i + m is a little confusing, maybe how this is done should be more explicitly written.
@luciankt luciankt added the visual-impurity Something looks off or unaesthetic label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
visual-impurity Something looks off or unaesthetic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luciankt