Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why was ignition 1.x removed from the conflict exception? #86

Closed
HenkPoley opened this issue Nov 15, 2021 · 11 comments
Closed

Why was ignition 1.x removed from the conflict exception? #86

HenkPoley opened this issue Nov 15, 2021 · 11 comments
Assignees
Labels

Comments

@HenkPoley
Copy link

HenkPoley commented Nov 15, 2021

Change/blame seen here: https://github.com/Roave/SecurityAdvisories/blame/bac54e18ee767f065d88b81c8517fb21cd6414ab/composer.json#L98

Was changed in commit: bad3752

I'm not quite seeing any recent change in https://github.com/FriendsOfPHP/security-advisories/tree/master/facade/ignition

Had a little monologue about it here 😅: https://twitter.com/HenkPoley/status/1460186738689773569

It currently blocks installing Laravel 6.x for me. Which is still in security support for about a year, so I'd be surprised if there actually was an unfix{ed,able} problem.

@Ocramius
Copy link
Member

GHSA-m5v7-pr32-mjx2

@Ocramius Ocramius self-assigned this Nov 15, 2021
@HenkPoley
Copy link
Author

Cool, the mentioned patch under that advisory is also applied to facades/ignition 1.16.14

facade/ignition@38e1b18

@Ocramius
Copy link
Member

That needs fixing in the published advisory.

@HenkPoley
Copy link
Author

Can I also submit a patch to the composer.json here, or is that just auto-generated ?

@Ocramius
Copy link
Member

This is just auto-generated, and is overwritten once an hour.

@HenkPoley
Copy link
Author

These GitHub advisories have no issue tracker 😅

You want me to write to nvd.nist.gov ?

Anyways, for now I'll have to remove roave/security-advisories in my project, and hope I'll remember to add it again later.

@Ocramius
Copy link
Member

Most likely need to contact GitHub support then.

I can't (and won't) fix data issues that are outside this repository's pertinence.

HenkPoley referenced this issue in facade/ignition Nov 15, 2021
@HenkPoley
Copy link
Author

HenkPoley commented Nov 15, 2021

Small update, if you look at the block of 'wip' on Jul 13, 2020: facade/ignition@1.16.14...1.16.15

You'll see that after "fixing" the security bug in 2.0.5, in the next version 2.0.6 (and going from 1.16.14 to 1.16.15) they gutted the problematic functionality. So there is no problem anymore in v1 as well.

Now I just need to update the CVE, which I've done before, just mail them. And somehow get GitHub to update their tracker.

@HenkPoley
Copy link
Author

Things are moving:

Now onto GitHub 😅

@Ocramius
Copy link
Member

@HenkPoley on our end, we'll try improving the commit messages, but not sure when we'll get to it.

See Roave/SecurityAdvisoriesBuilder#451

@HenkPoley
Copy link
Author

HenkPoley commented Nov 19, 2021

👀 GHSA-m5v7-pr32-mjx2

☺️ bc2442b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants