[Paywalls V2] Convert Codable structs to classes #4665
Merged
+607
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build decreased size
Paywalls 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| RevenueCat.OfferingsFactory.OfferingsFactory | ⬇️ -108.9 kB |
| Code Signature | ⬇️ -96.9 kB |
| RevenueCatUI.IconComponentViewModel.IconComponentViewModel | ⬇️ -70.2 kB |
| RevenueCatUI.ImageComponentViewModel.ImageComponentViewModel | ⬇️ -69.3 kB |
| DYLD.String Table | ⬆️ 53.2 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
joshdholtz
commented
Jan 14, 2025
Comment on lines
+81
to
+89
| let visible = other?.visible ?? base?.visible | ||
| let baseUrl = other?.baseUrl ?? base?.baseUrl | ||
| let iconName = other?.iconName ?? base?.iconName | ||
| let formats = other?.formats ?? base?.formats | ||
| let size = other?.size ?? base?.size | ||
| let padding = other?.padding ?? base?.padding | ||
| let margin = other?.margin ?? base?.margin | ||
| let color = other?.color ?? base?.color | ||
| let iconBackground = other?.iconBackground ?? base?.iconBackground |
There was a problem hiding this comment.
Had to do this because Swift compiler was timing out 🤷♂️
joshdholtz
force-pushed
the
paywalls-v2/move-codable-structs-to-classes
branch
from
39f6e72 to
0e4fd29
Compare
MarkVillacampa
approved these changes
Jan 14, 2025
This was referenced Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were getting random-ish
EXC_BAD_ACCESSafter the merge of the badge PR. It took some debuggin and it turned out..When decoding 5-ish paywall v2 in an
OfferingsResponse, thestructstructure while in the encoder would just fail.Note that this is in the ENCODER... and not the DECODER. So this was happening when we decode string response to Swift object and then encode back for storage.
Description
After some debugging and experimentation with Mark, it was our conclusion that our OfferingsResponse struct with the Paywalls V2 struct were causing some sort of struct structure that was WAY too big causing some sort of buffer overflows or something.
We experiment with converting one struct to a class and it made the issue go away. So we continue this in the PR to convert all Paywalls V2 components that are codable from structs (value type) to classes (reference type) to mitigate this issue.