feat: [CustomerCenter] Introduce CustomerCenterNavigationLink #4664
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpallares
reviewed
Jan 14, 2025
RevenueCatUI/CustomerCenter/Views/CustomerCenterNavigationLink.swift
Outdated
Show resolved
Hide resolved
ajpallares
reviewed
Jan 14, 2025
RevenueCatUI/CustomerCenter/Views/CustomerCenterNavigationLink.swift
Outdated
Show resolved
Hide resolved
ajpallares
approved these changes
Jan 14, 2025
1 build increased size
Paywalls 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 130.1 kB |
| Code Signature | ⬆️ 5.0 kB |
| Other | ⬆️ 56.4 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
ajpallares
approved these changes
Jan 15, 2025
RevenueCatUI/CustomerCenter/Views/CustomerCenterNavigationLink.swift
Outdated
Show resolved
Hide resolved
facumenzella
commented
Jan 15, 2025
RevenueCatUI/CustomerCenter/Views/CustomerCenterNavigationLink.swift
Outdated
Show resolved
Hide resolved
|
Thanks @ajpallares |
facumenzella
commented
Jan 15, 2025
|
Just a heads up that I've added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR aims to reduce ambiguity in how
CustomerCenterViewis used. Together withpresentCustomerCenter,CustomerCenterNavigationLinkbecomes the recommended approach for navigating toCustomerCenterView.Description
Following up on #4622 and based on feedback from @hiddevdploeg, we are introducing
CustomerCenterNavigationLink.The primary objective is to offer a straightforward method for integrating
CustomerCenterViewinto an existingNavigationView, without requiring developers to handle theisEmbeddedInNavigationStackparameter manually.