Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds X-Is-Debug-Build header #4364

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Adds X-Is-Debug-Build header #4364

merged 3 commits into from
Oct 10, 2024

Conversation

JayShortway
Copy link
Member

@JayShortway JayShortway commented Oct 9, 2024 •
edited
Loading

As the title says. Some details:

  • SystemInfo has a new isDebugBuild property.
  • HTTPClient reads this property and sets the X-Is-Debug-Build header accordingly.
  • 2 tests were added to HTTPClientTests.
  • Backend test snapshots were adjusted.

Note: I highly recommend reviewing the first 2 commits separately from the 3rd, as that one is huge because of all the backend snapshots.

Android implementation: RevenueCat/purchases-android#1873

@JayShortway JayShortway added pr:other pr:force_minor Forces a minor release labels Oct 9, 2024
@JayShortway JayShortway self-assigned this Oct 9, 2024
@JayShortway JayShortway mentioned this pull request Oct 9, 2024
Merged
@JayShortway JayShortway marked this pull request as ready for review October 10, 2024 13:58
@JayShortway JayShortway requested a review from a team October 10, 2024 13:58
aboedo
aboedo approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@aboedo aboedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol GH really doesn't get along with that many file changes

@aboedo
Copy link
Member

aboedo commented Oct 10, 2024

the recommendation to review the commits separately is :chefskiss:

@JayShortway JayShortway merged commit 57766ce into main Oct 10, 2024
7 checks passed
@JayShortway JayShortway deleted the is-debug-build branch October 10, 2024 15:00
This was referenced Oct 16, 2024
Closed
Closed
Closed
@JayShortway JayShortway removed the pr:force_minor Forces a minor release label Oct 21, 2024
This was referenced Oct 21, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboedo aboedo aboedo approved these changes

Assignees

@JayShortway JayShortway

Labels
pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JayShortway @aboedo