-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds actionlint to lint GitHub Actions workflows #4326
Conversation
Back to draft, because repository rules restrict usage of actionlint. |
This is ready for review. If it's approved, I'll update the repository settings to allow actionlint (and GHA's checkout action). If you disagree, we can close this. No biggie. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@tonidero @aboedo Had to make these changes to - run: echo ::set-output name=branch::$(gh pr view $PR_NO --repo $REPO --json headRefName --jq '.headRefName')
+ run: echo "branch=$(gh pr view "$PR_NO" --repo "$REPO" --json headRefName --jq '.headRefName')" >> "$GITHUB_OUTPUT"
Please have a looksie. |
Since we have a relatively complex GitHub Actions workflow, I figured it makes sense to add a linter to automatically catch errors. I've been using the online variant of this linter any time some workflow isn't working: https://rhysd.github.io/actionlint/. The same was recently merged to purchases-kmp: RevenueCat/purchases-kmp#227.