Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control the resolution going to the remote operator #9

Closed
mjsobrep opened this issue Jan 16, 2020 · 6 comments
Closed

Control the resolution going to the remote operator #9

mjsobrep opened this issue Jan 16, 2020 · 6 comments

Comments

@mjsobrep
Copy link
Member

Currently the WebRTC feeds are really really heavy. We have the resolution set going from the remote pc to the robot, but not the other way around. The remote operator only really needs 400x??? but is getting 1920x1080. We need a way to fix that.

  • Could potentially have a setting in the website javascript that handles this, but I don't think so
  • Maybe there is something in the webrtc ros code that could handle this. Something is happening here but I can't figure out what.
  • Worst case we could resize the images before they make it to the webrtc ros server, create new nodes with something like /upperrealsense/small that have the desired size and let the server work off of that.
@mjsobrep
Copy link
Member Author

I think that the AdaptFrame call gets the target roi and frame size. The changes are then implemented a few lines below: https://github.com/RobotWebTools/webrtc_ros/blob/77a0db1551d6f0e96cc9e69bc1982107d99336c3/webrtc_ros/src/ros_video_capturer.cpp#L86

@mjsobrep
Copy link
Member Author

I put up an issue for this on the parent repo

@mjsobrep
Copy link
Member Author

I used a technique where a separate node makes them smaller: 3518889 This still isn't great. If we can get the #13 working, then I think this would be satisfactory

@mjsobrep
Copy link
Member Author

Ok, I think we have this working. I want to throttle the frame rate to 15 fps though.

@mjsobrep
Copy link
Member Author

I also want to throttle the frame rate of the remote operator being captured by webrtc

@mjsobrep
Copy link
Member Author

mjsobrep commented Mar 7, 2020

closed in #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant