You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
2. Split identifiers into asset and code identifiers
Assets are loaded by:
asset identifier
Code is loaded by:
code identifier, OR
code prop, ELSE
blank
This has been done by:
Update editor-ui to allow two identifiers: asset-identifier and code-identifier
Update editor-api to add endpoint for assets only (easy, as above)
Update editor-api to add endpoint for code only (easy)
Draft spike
This has been drafted out in the associated branch which splits out the asset loading from the project loading.
Using Redux devtools we can see the assets from the specified project are available to the user.
For HTML projects, as we can't provide the project type via props, this can be achieved loading a blank HTML project which will in turn set the project type.
You can preview this using these project identifiers:
A comprehensive, robust, reliable option as it allows specific loading of different assets and code, without having to overwrite code. This should prevent mistakes or unstable situations.
API work required is simple, just splitting the response into two endpoints, one for the assets and the other for the code
Backwards compatible, the new assets and code props will supplement the existing identifier prop
Considerations
There will be an increase in API calls, as a project with separate identifiers will now be making two calls.
This is mitigated by preserving existing identifier prop and routes which will load both assets and code when they're the same, with the new props only being used when the code and assets are different.
2. Split identifiers into asset and code identifiers
Assets are loaded by:
Code is loaded by:
code
prop, ELSEThis has been done by:
editor-ui
to allow two identifiers:asset-identifier
andcode-identifier
editor-api
to add endpoint for assets only (easy, as above)editor-api
to add endpoint for code only (easy)Draft spike
This has been drafted out in the associated branch which splits out the asset loading from the project loading.
Using Redux devtools we can see the assets from the specified project are available to the user.
For HTML projects, as we can't provide the project type via props, this can be achieved loading a blank HTML project which will in turn set the project type.
You can preview this using these project identifiers:
Pros
identifier
propConsiderations
identifier
prop and routes which will load both assets and code when they're the same, with the new props only being used when the code and assets are different.Originally posted by @conorriches in #868 (comment)
Notes
code
The text was updated successfully, but these errors were encountered: