Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Add logfile #1722

Open
5 tasks
Tracked by #1717
nirs opened this issue Dec 12, 2024 · 0 comments
Open
5 tasks
Tracked by #1717

e2e: Add logfile #1722

nirs opened this issue Dec 12, 2024 · 0 comments
Assignees
Labels
test Testing related issue

Comments

@nirs
Copy link
Member

nirs commented Dec 12, 2024

The e2e logs are not detailed enough for debugging. We want to add detailed DEBUG level message. This will be too much info for the console so we need a log file. A log file is good idea anyway since it is hard to insepct the logs in the console, specially after running commands with lot of output.

Tasks:

  • Add logfile in the current directory, using the name of the e2e executable (e.g. ramen-e2e.log)
  • Create the log file by default
  • Use DEBUG level to log file, INFO for console
  • Upload the log as build artifacts in e2e job
  • Remove caller (file:lineno) from console logs

Example similar zap logging configuration:
https://github.com/nirs/kubectl-gather/blob/baccfc4a37aa9edbecfe466563a15bc23e48cc13/cmd/root.go#L133

Initial work: #1607
Quick hack: #1723

@nirs nirs added the test Testing related issue label Dec 12, 2024
@nirs nirs mentioned this issue Dec 12, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing related issue
Projects
None yet
Development

No branches or pull requests

2 participants