Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rust toolchain to nightly-2024-10-11 #585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Rahix
Copy link
Owner

@Rahix Rahix commented Sep 25, 2024

Time for another toolchain upgrade to fix a number of known compiler bugs.

@Rahix
Copy link
Owner Author

Rahix commented Sep 25, 2024

@Patryk27, some CI jobs are failing with

out of range branch target (expected an integer in the range -4096 to 4095)

is this still one of the known problems or something new?

@Patryk27
Copy link
Contributor

This is known, it’s already fixed in LLVM, but not yet backported - it should be in rustc within a couple days hopefully; I’ll let you know, so we can wait before bumping the toolchain here to get all of the fixes 🙂

@Rahix Rahix changed the title Upgrade rust toolchain to nightly-2024-09-24 Upgrade rust toolchain to nightly-2024-10-01 Oct 2, 2024
@Patryk27
Copy link
Contributor

@Rahix I think we should be good now - could you bump to the newest toolchain? 👀

@Rahix Rahix changed the title Upgrade rust toolchain to nightly-2024-10-01 Upgrade rust toolchain to nightly-2024-10-11 Oct 12, 2024
@Rahix
Copy link
Owner Author

Rahix commented Oct 12, 2024

@Patryk27, unfortunately it looks like we are still hitting the dreaded error: out of range branch target with nightly-2024-10-11? 😞

Just to check, I also tried nightly-2024-10-12, but I can still reproduce the error message...

@Patryk27
Copy link
Contributor

Patryk27 commented Oct 12, 2024

Ouch, my fault! It seems that llvm/llvm-project#109124 wasn't backported - I'll handle it tomorrow. Other commits seem to be in place, though (e.g. #573 is fixed), so we're mostly ready 😄

@Rahix
Copy link
Owner Author

Rahix commented Oct 13, 2024

No worries! Just ping me once the patch has hit nightly Rust, then I'll give it another shot :)

Thanks for all your compiler work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants