-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compute block config validation #5
Open
PaulKalho
wants to merge
23
commits into
main
Choose a base branch
from
issue/compute-block-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mottegk
approved these changes
Nov 7, 2024
@mottegk thanks for taking a look! |
PaulKalho
force-pushed
the
issue/compute-block-config
branch
from
November 11, 2024 02:38
51912ff
to
1e79770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
Closes #4
Explaination of the config:
Each compute block has some metadata (e.g.
name
,author
) it also contains a link to its docker-image.It lists the entrypoints, which should have the same name as the functions which are "decorated" with the
@entrypoint
decorator.Each
entrypoint
can have so calledenvs
these can be used to configure the functionality of an entrypoint and should describe Variables that are shared within the entrypoints functionality.Each
entrypoint
can have an unspecified amount ofinputs
andoutputs
. Which, in the first Version, can be of the following types:db_table
,file
These
inputs
andoutputs
can also be configured using theconfig
block. Strictly speaking, these are also ENV-Variables however for semantics these are grouped to the input (as they configure functionality for the input (e.g. DB_HOST, DB_PORT)).The values of the config keys should be the default values, provided by the ComputeBlock (TODO: Validate)
Null
within the config, the user of the ComputeBlock must manually set this configuration, or StartUp of the ComputeBlock will failOf course, the ComputeBlock developer can also define private ENV-Variables that must not be reflected within the config yaml (e.g. a shared
DB_HOST
that is not configurable orDB_PASS
)Outputs:
There are currently two types of outputs:
db_table
,file
they have the same characteristics as the corresponding input types, however, they cannot be optional.