Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted dependencies on pydantic to the newest v1.* version #197

Closed
wants to merge 2 commits into from

Conversation

sjohnen
Copy link
Collaborator

@sjohnen sjohnen commented Jul 6, 2023

should solve #196

@tstorek tstorek requested a review from djs0109 July 8, 2023 09:53
@tstorek tstorek mentioned this pull request Jul 8, 2023
@djs0109
Copy link
Contributor

djs0109 commented Jul 11, 2023

@sjohnen Thank you for the quick implementation! As @tstorek mentioned, we will try to migrate to Pydantic V2 as soon as possible. Then this issue is also solved.

@djs0109
Copy link
Contributor

djs0109 commented Jul 24, 2023

@tstorek I would like first to merge this PR and make a release before the pydantic migration comes. My concern is for example, filip now cannot be used to build images because of this version issue. BTW, have you ever met this error below? It runs through in my local environment but fails in CI. It seems that the tests.semantics.models is actually ignored by git.

FAILED tests/semantics/test_semantics_models.py::TestSemanticsModels::test_4_model_relation_field_validation - AssertionError: 'RestrictionType.some (Class2 or Class4)' != 'some (Class2 or Class4)'
- RestrictionType.some (Class2 or Class4)
? ----------------
+ some (Class2 or Class4)

@djs0109
Copy link
Contributor

djs0109 commented Jan 2, 2024

Can be closed with the new release v0.3.0

@djs0109 djs0109 closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants