-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Relationships with ContextBrokerClient update_entity #145
Comments
@dnikolay-ebc I can look into it but I think that this is intended behavior because we see relationships as rather static that should not be updated by bulk operations. Especially, since incomplete updates would accidentally overwrite existing information. If you want to update them you can use one of the other functions provided. I already explained this a little here #92. |
@dnikolay-ebc can we close this? |
@dnikolay-ebc please, reopen if required! |
@tstorek In our opinion, relationships are kind of static but we need the ability to adapt them - and not just with the workaround of first deleting them and creating a new one. Do you have any reason why we should not pursue this way? |
@SBlechmann I think that the easiest way would be add an option the |
@tstorek is there a reason why each of these functions update_entity, update_entity_relationships and update_entity_properties cannot call update_or_append_entity_attributes with attr=entity.get_attributes, attr=entity.get_relationships and attr=entity.get_properties respectively ? |
Describe the bug
ContextBrokerClient -> update_entity
callsupdate_or_append_entity_attributes
withattrs=entity.get_properties()
.This has the consequence that all relationships, even newly created ones, are ignored.
Is there any reason why
update_entity
is not usingentity.get_attributes()
?The text was updated successfully, but these errors were encountered: