-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
81 sup ctrl interfaces #82
Conversation
@PatrickHenkel1 I want to keep the changes in the valve control models as the current main has some wrong annotations which are removed automatically by Dymola. Can you do the review? |
Thank you for making a Pull Request to BESMod! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/81_supCtrlInterfaces/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/81_supCtrlInterfaces/charts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaxBerktoldRWTH : I used the standard supervisory control block to possibly allow for Modelica-internal supervisory control. Thus, the names slightly change, you have to override the defaults the same way the other signals are overridden.
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/81_supCtrlInterfaces/charts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and work, going to merge this now.
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/81_supCtrlInterfaces/charts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Although to be honest I'm not 100% sure what all the changes do.
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/81_supCtrlInterfaces/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /81_supCtrlInterfaces/charts/
This PR closes #81.
I explicitly did not add "Modelica internal" supervisory control as we do not have a use-case for this yet and a simple
extends
of the control subsystem enables the addition of a then naming independent Modelica internal supervisory control.