31 add hydraulic modules based on bdh and bagarella #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent high order models to the demand system
… necessary connection for the demand system
… on move_class script
…ttps://github.com/RWTH-EBC/BESMod into 31-Add-hydraulic-modules-based-on-BDH-and-Bagarella
…ttps://github.com/RWTH-EBC/BESMod into 31-Add-hydraulic-modules-based-on-BDH-and-Bagarella
…ttps://github.com/RWTH-EBC/BESMod into 31-Add-hydraulic-modules-based-on-BDH-and-Bagarella
…ttps://github.com/RWTH-EBC/BESMod into 31-Add-hydraulic-modules-based-on-BDH-and-Bagarella
|
@HvanderStok Can you provide short feedback if the current version works? If so, I would go ahead and merge this without review, as the changes are too much to review, and were already successfully used for various projects |
|
Yes, everything is working for me. I also did a complete new installation with all dependencies, which also worked fine. |
FWuellhorst
deleted the
31-Add-hydraulic-modules-based-on-BDH-and-Bagarella
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31
Closes #70
Closes #66
Closes #33