You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This throws an error when invoking %footgun() that there is an "Invalid macro parameter name." It seems to be interpreting <= 1, "Well, 1 > as a parameter despite the vastly different contexts. Similar code written for 1.81 didn't run into this issue. I've encountered this happening on strings that contain < and > with unrelated symbols in the middle as well, so my assumption is detection of macro parameters in strings is far too eager than it was in 1.81.
Tested on both randombot and linux on version 1.91.
The text was updated successfully, but these errors were encountered:
// RPG Hacker: Added checking for space here, because this code would consider
// if a < b && a > c
// a macro arg expansion. In practice, this is still a sloppy solution and is
// likely to fail in some edge case I can't think of right now. Should parse
// this in a much more robust way at some point...
if (*end=='')
looks like we need to hack this condition some more.... and i have no idea what we're gonna do in asar 2.0, when if conditions become normal expressions and thus don't need to have the extra space there. i hate how overloaded these symbols are in general.......
worst case I'd not mind having escaped < > in strings as an option, though I figure that wouldn't be ideal in general. Otherwise something like an explicit evaluation context ( usually curly braces in other languages ) seems like itd be a breaking change which may be undesirable, but maybe ok for 2.0 if everyone agreed?
This throws an error when invoking
%footgun()
that there is an "Invalid macro parameter name." It seems to be interpreting<= 1, "Well, 1 >
as a parameter despite the vastly different contexts. Similar code written for 1.81 didn't run into this issue. I've encountered this happening on strings that contain < and > with unrelated symbols in the middle as well, so my assumption is detection of macro parameters in strings is far too eager than it was in 1.81.Tested on both randombot and linux on version 1.91.
The text was updated successfully, but these errors were encountered: