-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the ipaPy2 tool suite #468
base: master
Are you sure you want to change the base?
Conversation
@francescodc87 we still need to fill in the |
@hechth can there be more than one owners? It would make sense to have both University of Liverpool and University of Manchester as owners |
@francescodc87 this TS owner is just the TS account and should not be used for attribution. Please use https://docs.galaxyproject.org/en/latest/dev/schema.html#tool-creator-organization to credit your universities. |
tools/ipapy2/ipapy2_clustering.xml
Outdated
</requirements> | ||
|
||
<command detect_errors="exit_code"><![CDATA[ | ||
python3 ${__tool_directory__}/ipapy2_clustering.py --i '${intensity_table}' --o '${output}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python3 ${__tool_directory__}/ipapy2_clustering.py --i '${intensity_table}' --o '${output}' | |
python3 '${__tool_directory__}/ipapy2_clustering.py' --i '${intensity_table}' --o '${output}' |
tools/ipapy2/ipapy2_clustering.xml
Outdated
@@ -0,0 +1,60 @@ | |||
<tool id="ipapy2_clustering" name="ipaPy2 clustering" version="@TOOL_VERSION@+galaxy0" python_template_version="3.5" profile="21.05"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<tool id="ipapy2_clustering" name="ipaPy2 clustering" version="@TOOL_VERSION@+galaxy0" python_template_version="3.5" profile="21.05"> | |
<tool id="ipapy2_clustering" name="ipaPy2 clustering" version="@TOOL_VERSION@+galaxy0" profile="21.05"> |
Description is missing atm
tools/ipapy2/ipapy2_clustering.py
Outdated
@@ -0,0 +1,16 @@ | |||
import click | |||
import pandas as pd | |||
from ipaPy2 import ipa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we put this small function into a <configfile>
or use argparse we could save the click dependency and the additional container.
Co-authored-by: Francesco Del Carratore <[email protected]>
@francescodc87 the main question is whether you want to maintain the wrappers yourself or not - I guess depending on that we should choose the toolshed owner. As Bjoern said, this is not about representation or credit - this is handled differently using the tags in the XML file. |
@hechth I see. Having recetox as owner is fine by me then |
Co-authored-by: Helge Hecht <[email protected]>
first draft
The first stub which doesn't take any parameters at this point is already available and can be used for further implementations. We still need to pass additional parameters to the tool.