Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature for logging out and moved settings icon to toolbar #146

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

this-Aditya
Copy link
Member

@this-Aditya this-Aditya linked an issue Jul 28, 2024 that may be closed by this pull request
@yatharthranjan
Copy link
Member

Hi, thanks for this. Unfortunately, it did not work for me. I built and ran with the corresponding changes in radar-android-commons

When I clicked logout, here is the flow:

  1. The app home reverted to the main screen but all the plugins disappeared.
  2. After I closed the app (from recents) and started it again, it was stuck on "Authorizing" splash screen for a long time (minutes)
  3. Then it timed out with an error saying invalid auth and Showed the QR code screen again
  4. After scanning the QR code, it got stuck in the Log In screen but never completed. I waited for a few minutes.
  5. Then I force stopped the app and opened it again, but this time, it immediately errors out with an Invalid token (or similar) on scanning the QR code.

@yatharthranjan
Copy link
Member

Additional Preference: The Logout button be moved to the settings page beside the Reset button and "Reset" be renamed to "Reset settings" for clarity.

@this-Aditya
Copy link
Member Author

Hi Yatharth, thanks for the info. Have you tried uninstalling the app? I think that will resolve the problem 🤔. If it doesn't, please let me know.

@this-Aditya
Copy link
Member Author

this-Aditya commented Nov 12, 2024

Additionally, this PR (along with the radar-commons-android) is now outdated due to the changes introduced in the coroutines PR. Please refrain from merging this and any other PRs at the moment, as doing so may create new conflicts. I will first update all the outdated PRs to align with the new approach and resolve any issues. Once that’s done, they can be safely merged.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add App Reset functionality in the settings
2 participants