Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of a new StandaloneVM/TemplateVM fails during the cloning process #9574

Open
Minimalist73 opened this issue Nov 12, 2024 · 2 comments
Labels
P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@Minimalist73
Copy link

Qubes OS release

r4.2.3

Brief summary

When creating a new StandaloneVM or TemplateVM that involves cloning, the creation fails with an error and prevents the new qube from being created.
Creating a qube of type AppVM works fine.

ERROR: TypeError('QubesBase.clone_vm() takes 3 positional arguments but 4 positional arguments (and 1 keyword-only argument) were given')

Steps to reproduce

  • Open the qube creation menu (new or old, it doesn't matter)
  • Select Type: StandaloneVM or TemplateVM
  • Select template to clone
  • Network to default
  • Create qube and get error

Expected behavior

StandaloneVM or TemplateVM is created.

Actual behavior

Ends in error and doesn't create anything.

@Minimalist73 Minimalist73 added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Nov 12, 2024
@Minimalist73
Copy link
Author

Minimalist73 commented Nov 12, 2024

Traced back to last week commit @marmarek:
QubesOS/qubes-core-admin-client@4df787b#diff-35e74c7eb62ebefca8aecf6d3f616cfc110ed62797851516bf86f93034676955R362
Removing the * in the position argument makes the qube creation menu work again.

Edit: Moving * after new_cls seems to work too.

@gunduzc
Copy link

gunduzc commented Nov 12, 2024

I have the exact same problem and I am able to reproduce this with a fresh QubesOS install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

No branches or pull requests

2 participants