-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighten doesn't work on black color #150
Comments
Lighten is based on a ratio (multiplication), not absolute values (addition), of the lightness channel in the HSL model. Therefore, the lightness of black is 0, when you lighten by 0.5, you're doing For the question of whether or not this is a bug, the answer is objectively "no" - whether or not it's preferred is an ongoing discussion in #53, one that I am very much open to. Feel free to chime in there :) Closing as a duplicate. |
I'm sorry, but I absolutely have to disagree. This package makes the bold statement:
Using |
@goyney You seem to have missed my paragraph about objectivity vs. subjectivity:
However, I don't see a comment there from you. Perhaps that would have been a good place to start 👍 |
Hi,
If you try
you'll get again
#000000
color.Is this a bug?
Cheers!
The text was updated successfully, but these errors were encountered: