-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native aarch64 GitHub Action workers #1371
base: main
Are you sure you want to change the base?
Use native aarch64 GitHub Action workers #1371
Conversation
Test run: https://github.com/IvanIsCoding/rustworkx/actions/runs/12943314687 edit: there are still some warnings like
Most likely we should make the aarch64 steps now wait with the other steps to build and publish |
Pull Request Test Coverage Report for Build 12971406453Details
💛 - Coveralls |
Hmm, that makes me think we have a configuration issue that's explicitly setting the image for aarch64 to x86_64. But that's a bit odd, because I think we only set an image explicitly on x86_64. |
This will go away when I refactor this PR. Right now, the aarch64 build is faster than the default build because i686 spends a lot of time compiling NumPy. So there could be a window of time where there could be no source/pre-compiled wheels for new platforms which is chaos. I will merge |
Simplified test build is running: https://github.com/IvanIsCoding/rustworkx/actions/runs/12971477288 I think we'll be able to just add aarch64 to the OS matrix. That would simplify our setup quite a lot edit: the wheels got built, this is very convenient! |
Closes #1367
In hindsight we should have used this before the release as the QEMU jobs are really unstable. I might need to backport this to the 0.16 branch and trigger a workflow again.
This is a copy of Qiskit/qiskit#13682. I will test it in my branch and check it works.