Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native aarch64 GitHub Action workers #1371

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

IvanIsCoding
Copy link
Collaborator

Closes #1367

In hindsight we should have used this before the release as the QEMU jobs are really unstable. I might need to backport this to the 0.16 branch and trigger a workflow again.

This is a copy of Qiskit/qiskit#13682. I will test it in my branch and check it works.

@IvanIsCoding IvanIsCoding added this to the 0.17.0 milestone Jan 24, 2025
@IvanIsCoding
Copy link
Collaborator Author

IvanIsCoding commented Jan 24, 2025

Test run: https://github.com/IvanIsCoding/rustworkx/actions/runs/12943314687

edit: there are still some warnings like

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

Most likely we should make the aarch64 steps now wait with the other steps to build and publish

@IvanIsCoding IvanIsCoding changed the title Use native aarch64 GitHub Action works Use native aarch64 GitHub Action workers Jan 24, 2025
@coveralls
Copy link

coveralls commented Jan 24, 2025

Pull Request Test Coverage Report for Build 12971406453

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.811%

Totals Coverage Status
Change from base Build 12940380885: 0.0%
Covered Lines: 18343
Relevant Lines: 19145

💛 - Coveralls

@mtreinish
Copy link
Member

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

Hmm, that makes me think we have a configuration issue that's explicitly setting the image for aarch64 to x86_64. But that's a bit odd, because I think we only set an image explicitly on x86_64.

@IvanIsCoding
Copy link
Collaborator Author

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

Hmm, that makes me think we have a configuration issue that's explicitly setting the image for aarch64 to x86_64. But that's a bit odd, because I think we only set an image explicitly on x86_64.

This will go away when I refactor this PR.

Right now, the aarch64 build is faster than the default build because i686 spends a lot of time compiling NumPy. So there could be a window of time where there could be no source/pre-compiled wheels for new platforms which is chaos.

I will merge musl and manylinux for aarch64 and put them with the main infrastructure now.

@IvanIsCoding
Copy link
Collaborator Author

IvanIsCoding commented Jan 26, 2025

Simplified test build is running: https://github.com/IvanIsCoding/rustworkx/actions/runs/12971477288

I think we'll be able to just add aarch64 to the OS matrix. That would simplify our setup quite a lot

edit: the wheels got built, this is very convenient!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Linux arm64 runners for the release process
3 participants