Fix PauliEvolutionGate (using product formulas) for all-identity Pauli terms
#13634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
stable backport potential
Cryoris
requested review from
alexanderivrii,
ShellyGarion and
a team
as code owners
|
One or more of the following people are relevant to this code:
|
Co-authored-by: Alexander Ivrii <[email protected]>
Pull Request Test Coverage Report for Build 12709550670Details
💛 - Coveralls |
ElePT
reviewed
Jan 10, 2025
| /// I_q0 X_q1 Y_q2 Z_q3 and will use a RZ rotation angle of 0.4. | ||
| /// ``(pauli_string, qubit_indices, rz_rotation_angle)``. An element of the form | ||
| /// ``("XIYZ", [0,1,2,3], 2)``, for example, is interpreted in terms of qubit indices as | ||
| /// I_q0 X_q1 Y_q2 Z_q3 and will use a RZ rotation angle of 2. |
There was a problem hiding this comment.
Given that you reordered the pauli string abovem shouldn't it be:
Suggested change
| /// I_q0 X_q1 Y_q2 Z_q3 and will use a RZ rotation angle of 2. | |
| /// X_q0 I_q1 Y_q2 Z_q3 and will use a RZ rotation angle of 2. |
There was a problem hiding this comment.
Whoops, yes -- good catch!
There was a problem hiding this comment.
Also the circuit doesn't match that string -- both fixed in 55a5357!
There was a problem hiding this comment.
Is there a point to add another test based on #13644? (calling hamiltonian_variational_ansatz)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
PauliEvolutionGate, if used with a product formula synthesis (this is the default),did not correctly handle all-identity terms in the operator:
Details and comments
Some minor corrections to docs are included.