Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change help text/description style #451

Open
stevepiercy opened this issue Aug 22, 2020 · 4 comments
Open

Change help text/description style #451

stevepiercy opened this issue Aug 22, 2020 · 4 comments
Labels
BS5 Bootstrap 4
Milestone

Comments

@stevepiercy
Copy link
Member

Change the help text/description from:

<p class="help-block" >Enter some text</p>

to default:

<small id="${oid}HelpBlock" class="form-text text-muted">

and for invalid:

<small id="${oid}HelpBlock" class="form-text text-danger">
@stevepiercy stevepiercy added the BS5 Bootstrap 4 label Aug 22, 2020
@stevepiercy stevepiercy added this to the 3.0.0 milestone Aug 22, 2020
@trollfot
Copy link

the notation "${oid}HelpBlock" in camel-case seems a bit of out what is currently done with the rest. Maybe "help-${oid}" ?

@stevepiercy
Copy link
Member Author

BS5 also uses div.class with form-text for help.

The id is camel case in BS5, but I much prefer snake case, as you suggest. I think I would prefer ${oid}-help, as it is better to first name the thing, then describe it. Do you have good reason to do the reverse, such as description-name?

@trollfot
Copy link

current, in the mapping_item template, we have "req-${oid}" and "item-${oid}". I thought it would be aligned with this kind of notation

@stevepiercy
Copy link
Member Author

OK, that makes sense. Let's stick with the existing pattern of req-${oid}. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BS5 Bootstrap 4
Projects
None yet
Development

No branches or pull requests

2 participants