Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-calling import in slash commands #2058

Closed
Lulalaby opened this issue May 8, 2023 · 4 comments · May be fixed by #1606
Closed

Re-calling import in slash commands #2058

Lulalaby opened this issue May 8, 2023 · 4 comments · May be fixed by #1606
Labels
bug Something isn't working priority: low Low Priority status: todo This issue needs work
Milestone
v2.5

Comments

@Lulalaby
Copy link
Member

Lulalaby commented May 8, 2023 •
edited
Loading

The following code runs on every call to this function.
We should move that up to the general imports.

pycord/discord/commands/core.py

Line 119 in a09e728

from ..ext.commands.errors import CommandError

@Lulalaby Lulalaby added bug Something isn't working priority: high High Priority status: todo This issue needs work python labels May 8, 2023
@Lulalaby Lulalaby added this to the v2.5 milestone May 8, 2023
@OmLanke OmLanke mentioned this issue May 21, 2023
Closed
@Dorukyum
Copy link
Member

Dorukyum commented Jun 7, 2023

Pretty sure it has to be this way to prevent a circular import.

@Lulalaby
Copy link
Member Author

Lulalaby commented Jun 7, 2023

oh

@OmLanke
Copy link
Contributor

OmLanke commented Jun 7, 2023 •
edited
Loading

Pretty sure it has to be this way to prevent a circular import.

Yes thats right. This should be fixed by #1606 as it cleans up the structure.

Another way I thought of would be checking type(exc) == "CommandError" in the except Exception as exc: block. Although I'm not sure if this works

@Middledot Middledot linked a pull request Jul 17, 2023 that will close this issue
feat: implement Invokable & BaseContext #1606
Open
5 tasks
@Dorukyum Dorukyum added priority: low Low Priority and removed on hold priority: high High Priority python labels Dec 2, 2023
@Dorukyum
Copy link
Member

Dorukyum commented Feb 2, 2024

I'm closing as this will be fixed with the refactoring of slash commands and probably won't be fixed independently.

@Dorukyum Dorukyum closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority: low Low Priority status: todo This issue needs work
Projects
Pycord Releases
Status: Done
Milestone
v2.5
Development

Successfully merging a pull request may close this issue.

feat: implement Invokable & BaseContext Middledot/pycord
3 participants
@Lulalaby @Dorukyum @OmLanke