Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python 3.13 on Windows #292

Closed
davidbrochart opened this issue Oct 9, 2024 · 5 comments
Closed

Support for Python 3.13 on Windows #292

davidbrochart opened this issue Oct 9, 2024 · 5 comments

Comments

@davidbrochart
Copy link

I'm trying to publish wheeld for pycrdt on Windows for Python 3.13 and I get an error suggesting that Python 3.13 is not found

🐍 Found CPython 3.8 at C:\hostedtoolcache\windows\Python\3.8.10\x64\python.exe, CPython 3.9 at C:\hostedtoolcache\windows\Python\3.9.13\x64\python.exe, CPython 3.10 at C:\hostedtoolcache\windows\Python\3.10.11\x64\python.exe, CPython 3.11 at C:\hostedtoolcache\windows\Python\3.11.9\x64\python.exe, CPython 3.12 at C:\hostedtoolcache\windows\Python\3.12.6\x64\python.exe, CPython 3.13
...
  = note: LINK : fatal error LNK1181: cannot open input file 'python313.lib'

I'm not sure I should report here, or if I'm doing something wrong on my side?

@messense
Copy link
Member

messense commented Oct 9, 2024

Python 3.13 isn't installed by default in Actions runner yet: https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#python

You can install it before building using setup-python action manually for the moment.

@messense messense closed this as completed Oct 9, 2024
@JacobCallahan
Copy link

@messense Perhaps I'm doing something wrong, but even after setup-python explicitly adds python 3.13 for all my platforms, maturin doesn't seem to find it and stops at python 3.12. Some links for reference:

Linux x86_64: https://github.com/JacobCallahan/Hussh/actions/runs/11261961543/job/31316640293?pr=19
Run summary view: https://github.com/JacobCallahan/Hussh/actions/runs/11261961543?pr=19
PR with workflow changes: JacobCallahan/Hussh#19

Thanks for your time!

@messense
Copy link
Member

@JacobCallahan See PyO3/maturin#2248

for now you can pass the list of python versions manually via -i, for example https://github.com/jupyter-server/pycrdt/actions/runs/11251137381/workflow#L27

@JacobCallahan
Copy link

@messense very nice! Do you know how soon that will be available in the action, if soon, then I might just hold off instead of doing a temporary workaround.

@JacobCallahan
Copy link

@messense i tried using maturin-action:main for a run to see if the change you linked would help, but it still doesn't look to have detected py3.13

https://github.com/JacobCallahan/Hussh/actions/runs/11308556582/job/31451536529?pr=19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants