Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNIX domain socket are not supported by default #63

Open
RaitoBezarius opened this issue Jul 23, 2024 · 1 comment
Open

UNIX domain socket are not supported by default #63

RaitoBezarius opened this issue Jul 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@RaitoBezarius
Copy link

It seems that the default handler uses PrometheusBuilder::new and uses a HTTP listener which doesn't work when Axum uses a UDS listener which should use the UDS listen for the Prometheus builder.

I'm not super knowledgeable about all that stuff so I'm not sure if there's a way to make this work by default out of the box without writing a MakeDefaultHandle that tries to detect if there's a UDS listen or a HTTP listen and switch the instantiation based on that.

@Ptrskay3
Copy link
Owner

I don't think this is something we plan to support out of the box.

There're a couple of ways implement this on your own — for instance with the latest addition of BaseMetricLayer you can setup your exporter however you like, completely decoupled from the rest this crate. I don't think I'll ever plan to work on this, but if it's really important to you (or for anybody else) to support this by default, I'll accept PRs.

@Ptrskay3 Ptrskay3 added the enhancement New feature or request label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants