Window component should handle props update #68
Comments
christopher-johnson
added a commit
to ubleipzig/research-and-demos
that referenced
this issue
Dec 1, 2018
handles prop updates in Window replaces binds with arrow functions excludes console in eslint adds build to .gitignore adds lerna.json
christopher-johnson
added a commit
to ubleipzig/research-and-demos
that referenced
this issue
Dec 1, 2018
closes ProjectMirador#66 adds ejected create react app configuration to app moves tests to subdirectories of components linting changes closes ProjectMirador#68 handles prop updates in Window replaces binds with arrow functions excludes console in eslint adds build to .gitignore adds lerna.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
there is an issue if a manifest is rendered by window and then the same manifest is loaded in the form that results in a "Cannot read property 'getLabel' of undefined error" in Window.render(). Window will not remount in this case, so the component should expect a props update and re-instantiate the viewer instance (and do a refetch for tiles, etc.) when the required manifest prop has been re-propagated from store. This can be done within ComponentDidUpdate.
The text was updated successfully, but these errors were encountered: