Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to work with a url-escaped image identifier when there is no identifier field #135

Open
hashimmm opened this issue Jul 17, 2014 · 1 comment

Comments

@hashimmm
Copy link

In the case where the @id received from an image information (info.json) request contains a url-escaped image identifier component, and there is no identifier field, for example:
"@id": "scheme://host:port/prefix/url%20escaped%2Fidentifier"

Mirador seems to incorrectly specify the tilesUrl for OpenSeaDragon (even though simply creating an OpenSeaDragon viewer separately and specifying the info request url as tilesUrl will work). Mirador displays thumbnails for the given image just fine, there's only an issue when prepping info for OSD.

According to the image API specification the identifier field shouldn't be required.

This can be fixed by changing json.identifier = matches[2]; to json.identifier = decodeURIComponent(matches[2]); in getImageHostUrl in iiif.js.

@azaroth42
Copy link
Contributor

+1

On Thu, Jul 17, 2014 at 12:17 AM, Hashim Muqtadir [email protected]
wrote:

In the case where the @id received from an image information (info.json)
request contains a url-escaped image identifier component, and there is no
identifier field, for example:
"@id": "scheme://host:port/prefix/url%20escaped%2Fidentifier"

Mirador seems to incorrectly specify the tilesUrl for OpenSeaDragon (even
though simply creating an OpenSeaDragon viewer separately and specifying
the info request url as tilesUrl will work). Mirador displays thumbnails
for the given image just fine, there's only an issue when prepping info for
OSD.

According to the image API specification
http://www-sul.stanford.edu/iiif/image-api/1.1/#info the identifier
field shouldn't be required.

This can be fixed by changing json.identifier = matches[2]; to json.identifier
= decodeURIComponent(matches[2]); in getImageHostUrl in iiif.js.


Reply to this email directly or view it on GitHub
ProjectMirador/mirador#135.

Rob Sanderson
Technology Collaboration Facilitator
Digital Library Systems and Services
Stanford, CA 94305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants