-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/issue 953 support for Bun #1308
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, I spoke too soon :/
I forgot that our NPM scripts still call out to node
lol, so of course when I removed that and run bun run build
it fails lol
Initializing active content...
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".svg" for /Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/src/assets/discord.svg
at new NodeError (node:internal/errors:405:5)
at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:136:11)
at defaultGetFormat (node:internal/modules/esm/get_format:182:36)
at defaultLoad (node:internal/modules/esm/load:101:20)
at ModuleLoader.load (node:internal/modules/esm/loader:417:13)
at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:288:22)
at new ModuleJob (node:internal/modules/esm/module_job:63:26)
at #createModuleJob (node:internal/modules/esm/loader:312:17)
at ModuleLoader.getJobFromResolveResult (node:internal/modules/esm/loader:265:34)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:251:17) {
code: 'ERR_UNKNOWN_FILE_EXTENSION'
}
So seems like some sort of adapter would be needed for this then. 😞
I guess we would have to implement a plugin somehow?
https://bun.sh/docs/bundler/plugins
d11db6b
to
2f55bb7
Compare
Related Issue
related to #1323
Summary of Changes
Documentation
trustedDependencies
to supportpostinstall
scripts with Bun, like for the puppeteer plugin--bun
flag for NPM scriptsTODO