Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to the pager on project listing page #250

Open
colleenskemp opened this issue Nov 4, 2021 · 6 comments
Open

Adjustments to the pager on project listing page #250

colleenskemp opened this issue Nov 4, 2021 · 6 comments

Comments

@colleenskemp
Copy link
Collaborator

Suggesting a design adjustment to the pagination on the project listing page. My thought is that this will look nicer moved to the bottom of the page.

@ralph - will you please provide design direction on this?

Please implement 10 projects per page at request of client.

@colleenskemp
Copy link
Collaborator Author

@brodavi - you mentioned that the addition of the pager was not insignificant time/effort-wise. Are adjustments to it similarly difficult of relatively straightforward now that we have the functionality there? We should only make adjustments as requested if it's the latter.

@brodavi
Copy link
Collaborator

brodavi commented Nov 4, 2021

@colleenskemp no, now that it is done, it shouldn't take much time to tweak.

@colleenskemp
Copy link
Collaborator Author

@brodavi - Can yo please move it to the bottom?

@brodavi
Copy link
Collaborator

brodavi commented Nov 16, 2021

this was done. already merged: #281

@shrutimehta13
Copy link
Collaborator

  1. 7 projects on a page. expected 10
  2. page numbering is odd. shows page 0 of 2 and page 1 of 2. expected 1 of 2 and 2 or 2

Screenshot 2021-11-22 at 4 11 07 PM

@brodavi
Copy link
Collaborator

brodavi commented Nov 23, 2021

PR #403

@brodavi brodavi assigned litenull and unassigned brodavi Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants