8267 fix normalize intensity #8286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix channel-wise intensity normalization for integer type inputs.
Signed-off-by: Adrian Voicu <[email protected]>
Fix channel-wise intensity normalization for integer type inputs.
Signed-off-by: Adrian Voicu <[email protected]>
I, advcu987 <[email protected]>, hereby add my Signed-off-by to this commit: b55a02e I, advcu987 <[email protected]>, hereby add my Signed-off-by to this commit: 28a0df1 I, advcu987 <[email protected]>, hereby add my Signed-off-by to this commit: bdb3604 Signed-off-by: advcu987 <[email protected]>
KumoLiu
reviewed
Jan 9, 2025
| @@ -907,6 +907,8 @@ def __call__(self, img: NdarrayOrTensor) -> NdarrayOrTensor: | |||
| if self.divisor is not None and len(self.divisor) != len(img): | |||
| raise ValueError(f"img has {len(img)} channels, but divisor has {len(self.divisor)} components.") | |||
|
|
|||
| img, *_ = convert_data_type(img, dtype=torch.float32) | |||
There was a problem hiding this comment.
Thanks for the fix. Seems we can remove the convert out side of the self._normalize to avoid convert multiple times here.
There was a problem hiding this comment.
Should we also check that the dtype of img isn't float16/float32/float64 and only do the conversion in that case?
There was a problem hiding this comment.
Yes, it would be a little more rigorous. Although in the non channel-wise version, we do the conversion directly. But yes if we could do the check, would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8267 .
Description
Fix channel-wise intensity normalization for integer type inputs.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.