Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree kernel requires exact label matches #39

Open
ArtPoon opened this issue Feb 8, 2017 · 1 comment
Open

Tree kernel requires exact label matches #39

ArtPoon opened this issue Feb 8, 2017 · 1 comment

Comments

@ArtPoon
Copy link
Contributor

ArtPoon commented Feb 8, 2017

In src/treestats.c, node labels (strings) are converted into integers using a deterministic heap sort and search. Thereafter, labels are compared as integer values within the kernel code. However, we may want match labels as patterns. For example, if a tip has multiple states A and B, it should match another tip in state A just as it matches tips in state B.

@ArtPoon ArtPoon added this to the Near future milestone May 8, 2017
@ArtPoon ArtPoon modified the milestones: Near future, version 0.3 Jan 29, 2018
@ArtPoon
Copy link
Contributor Author

ArtPoon commented Jan 29, 2018

I think the best way to implement this is to have a user-specified weight matrix. For example, in the situation where there are three labels A, B and C, we can use this matrix:

   A  B  C
A  1  1  0
B  1  1  0
C  0  0  1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant