Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 Make Distribution.currency of type Asset #261

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

prashantasdeveloper
Copy link
Contributor

Description

Make Distribution.currency of type Asset

Breaking Changes

🧨 Type of currency in Distribution entity has been changed to Asset type

JIRA Link

DA-1353

Checklist

  • Updated the Readme.md (if required) ?

BREAKING CHANGE: 🧨 Type of `currency` in `Distribution` entity has been changed to `Asset`
type
Copy link

sonarcloud bot commented Oct 24, 2024

Copy link
Contributor

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but are you sure currency is always an existing asset?

schema.graphql Show resolved Hide resolved
@prashantasdeveloper
Copy link
Contributor Author

/fast-forward

@polymesh-bot polymesh-bot merged commit cb1b4cd into alpha Oct 25, 2024
5 checks passed
@polymesh-bot polymesh-bot deleted the feat/DA-1353 branch October 25, 2024 04:27
@polymesh-bot
Copy link
Contributor

🎉 This PR is included in version 17.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@polymesh-bot
Copy link
Contributor

🎉 This PR is included in version 17.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants