Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new events for 7.x chain and some other fixes #259

Merged
merged 7 commits into from
Oct 17, 2024
Merged

Conversation

prashantasdeveloper
Copy link
Contributor

@prashantasdeveloper prashantasdeveloper commented Oct 16, 2024

Description

  • Portfolio movements incorrectly had ticker value populated against asset ID field for Non Fungible tokens. This fixes the issue. (DA-1327)
  • Adds new events and extrinsics from latest 7.x chain (DA-1333)
  • Add new handler for mapping event TickerUnlinkedFromAsset (DA-1333)
  • Update logic of asset ID generation for legacy tickers (to generate valid UUID) (DA-1333)
  • Bump @polymeshassociation/polymesh-types to 5.14.0 (DA-1331)

Breaking Changes

NA

JIRA Link

DA-1327, DA-1333, DA-1331

Checklist

  • Updated the Readme.md (if required) ?

@prashantasdeveloper
Copy link
Contributor Author

I haven't added the migration because next change with updated assetID calculation using genesis hash requires full re-sync. Just FYI query to fix the data would have been -

update portfolio_movements pm 
set asset_id = a.id
from assets a 
where a.ticker = pm.asset_id;

VictorVicente
VictorVicente previously approved these changes Oct 16, 2024
Copy link
Contributor

@VictorVicente VictorVicente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be related to some unit test?

@prashantasdeveloper prashantasdeveloper changed the title fix: 🐛 Asset value for non-fungible portfolio movements Add new events for 7.x chain and some other fixes Oct 17, 2024
Copy link

sonarcloud bot commented Oct 17, 2024

@prashantasdeveloper
Copy link
Contributor Author

/fast-forward

@polymesh-bot polymesh-bot merged commit 5ac1789 into alpha Oct 17, 2024
6 checks passed
@polymesh-bot polymesh-bot deleted the fix/DA-1327 branch October 17, 2024 12:31
@polymesh-bot
Copy link
Contributor

🎉 This PR is included in version 16.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@polymesh-bot
Copy link
Contributor

🎉 This PR is included in version 16.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants