V7 chain support #295
Draft
V7 chain support #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: 🧨 - `createdAt` and `venue` are now optional in `InstructionModel`. - `ticker` has been renamed to `asset` in `PreApprovedModel` and `CorporateActionModel`
BREAKING CHANGE: 🧨 - All the asset related endpoints (starting with `assets/` or associated with `assets` tag) now also accept asset ID as permissible value along with ticker for the corresponding path param from 7.x chain. - The `ticker` property of `CheckpointScheduleModel` has been renamed to `asset`. - The query param `ticker` has been renamed to `asset` for the endpoint GET `portfolios/identities/:did/portfolios/:id/transactions`. - The property `ticker` has been renamed to `asset` in `PortfolioMovementDto`. This affects the endpoint POST `portfolios/identities/:did/portfolios/move-assets`. - The endpoint POST `settlements/instructions/create` now accepts asset ID as well for on chain legs, as possible value for `asset` body params. - The endpoint GET `settlements/leg-validations` now accepts asset ID as well, as possible value for `asset` body param from 7.x chain. - The `asset` property of `CorporateActionModel`, `PreApprovedModel`, `MetadataEntryModel` now return asset ID values from 7.x chain.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Link
Insert JIRA url here
Changelog / Description
Add description in points. Use bulleting/numbering to list the changes/features.
Checklist -