From 3c204deab3020f156fa9dbc8913c50bddf5b1ec9 Mon Sep 17 00:00:00 2001
From: Henrique Nogara <nogara.henrique@gmail.com>
Date: Tue, 22 Oct 2024 09:45:48 -0300
Subject: [PATCH] Remove old InstructionFailed event (#1744)

---
 pallets/common/src/traits/settlement.rs                    | 2 --
 .../tests/src/settlement_pallet/execute_instruction.rs     | 7 -------
 pallets/settlement/src/lib.rs                              | 1 -
 3 files changed, 10 deletions(-)

diff --git a/pallets/common/src/traits/settlement.rs b/pallets/common/src/traits/settlement.rs
index 7c0863527..0ab96ed4f 100644
--- a/pallets/common/src/traits/settlement.rs
+++ b/pallets/common/src/traits/settlement.rs
@@ -47,8 +47,6 @@ decl_event!(
         VenuesBlocked(IdentityId, AssetId, Vec<VenueId>),
         /// Execution of a leg failed (did, instruction_id, leg_id)
         LegFailedExecution(IdentityId, InstructionId, LegId),
-        /// Instruction failed execution (did, instruction_id)
-        InstructionFailed(IdentityId, InstructionId),
         /// Instruction executed successfully(did, instruction_id)
         InstructionExecuted(IdentityId, InstructionId),
         /// Venue not part of the token's allow list (did, AssetId, venue_id)
diff --git a/pallets/runtime/tests/src/settlement_pallet/execute_instruction.rs b/pallets/runtime/tests/src/settlement_pallet/execute_instruction.rs
index 58cf3bf5c..25ee0d525 100644
--- a/pallets/runtime/tests/src/settlement_pallet/execute_instruction.rs
+++ b/pallets/runtime/tests/src/settlement_pallet/execute_instruction.rs
@@ -187,13 +187,6 @@ fn execute_instruction_storage_rollback() {
                 Error::<TestStorage>::FailedToReleaseLockOrTransferAssets.into()
             ))
         );
-        assert_eq!(
-            system_events.pop().unwrap().event,
-            crate::storage::EventTest::Settlement(RawEvent::InstructionFailed(
-                SettlementDID.as_id(),
-                instruction_id
-            ))
-        );
         assert_eq!(
             system_events.pop().unwrap().event,
             crate::storage::EventTest::Settlement(RawEvent::LegFailedExecution(
diff --git a/pallets/settlement/src/lib.rs b/pallets/settlement/src/lib.rs
index 75678e127..fdcda7d4f 100644
--- a/pallets/settlement/src/lib.rs
+++ b/pallets/settlement/src/lib.rs
@@ -1322,7 +1322,6 @@ impl<T: Config> Module<T> {
                 instruction_id,
                 failed_leg_id,
             ));
-            Self::deposit_event(RawEvent::InstructionFailed(caller_did, instruction_id));
         }
 
         tx_result