-
Notifications
You must be signed in to change notification settings - Fork 84
noink doesn't disable ripple for first click #105
Comments
I've noticed that the ripple appears even without a click if you focus on another window (eg this one), and then switch back to the one with the slider in it. Very odd. |
Are ink and focus different things for this element? I actually don't see an ink effect when you play with the demos at https://elements.polymer-project.org/elements/paper-slider?view=demo:demo/index.html&active=paper-slider. I do see focus rings. IOW, it's unclear with |
@ebidel is right. It should only show the focus ring if you navigate to the slider using the keyboard. This is how it's described in the material design spec. Also, there isn't a way to change the color of the focus ring independently from the knob as the color should match |
There's definitely something odd going on. Using the demo in another tab, and switching back and forth between this tab and the demo using a mouse click, sometimes there is a ring, and sometimes not. https://drive.google.com/open?id=0B3rVVZ4job1EeWQxSW9CUHBQLWs |
@davidmaxwaterman yes, that is expected. Try focusing the textarea to respond back on this page and then switch back and forth between this and other tab. You should see how the textarea lights up again. This behavior allows to see the currently active element (or focused), so the element is keyboard actionable. In material design, the focus state has a ripple given that the default focus ring [1] is disabled.
|
I'm sorry, but I think you didn't notice how it is only sometimes highlighted...that surely can't be expected or intentional under any circumstances. |
Actually, something always happens, but it doesn't always /settle/ on the same 'highlighted' state. I find it difficult to understand why that would be intended. |
@davidmaxwaterman btw I moved this issue to PolymerElements/paper-behaviors#63 |
@blasten : when I read PolymerElements/paper-behaviors#63 it doesn't read like it's the same problem at all... |
If I add the noink attribute, I still get a ripple effect for the first click, though I don't subsequent clicks (maybe - it seems like there is a situation where the ripple effect also occurs after the first one).
Any ideas?
The text was updated successfully, but these errors were encountered: