Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Esc' key unexpectedly propagates to parent nodes. #77

Open
freshp86 opened this issue Sep 14, 2016 · 4 comments
Open

'Esc' key unexpectedly propagates to parent nodes. #77

freshp86 opened this issue Sep 14, 2016 · 4 comments

Comments

@freshp86
Copy link

See repro at https://jsfiddle.net/no958fqr/.

This is causing problems, for example when a paper-dropdown-menu resides within a dialog. Hitting the 'esc' key when the dropdown menu is focused should only close the dropdown menu, but not the dialog. This is affecting Chrome's new Settings page, see https://bugs.chromium.org/p/chromium/issues/detail?id=638518.

/cc @danbeam

@danbeam
Copy link
Contributor

danbeam commented Sep 15, 2016

/cc @bicknellr @notwaldorf

@danbeam
Copy link
Contributor

danbeam commented Sep 20, 2016

@tjsavage

@JanMiksovsky
Copy link

@valdrinkoshi Is this already addressed by the fix for PolymerElements/iron-overlay-behavior#212?

@valdrinkoshi
Copy link
Member

No, this is different, as the request is to have the overlay stop the event's propagation.
@freshp86 @danbeam iron-overlay-behavior already provides the event iron-overlay-canceled which detail is the source event. You could listen to that event and stop the propagation yourself too event.detail.stopPropagation()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants