Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving focus to next item (in paper-menu) does not skip disabled items #57

Closed
1 task done
giltza opened this issue Apr 5, 2016 · 2 comments
Closed
1 task done

Comments

@giltza
Copy link
Contributor

giltza commented Apr 5, 2016

Description

When using 'paper-menu' where one of the 'paper-item's is disabled, traversing the items using up/down keyboard keys or typing the first letter of one of the item's titles does not skip disabled paper-items.

Expected outcome

Disabled paper-items should not be focus-able and should be ignored when using the following methods: _focusNext, _focusPrevious, focusWithKeyboardEvent in IronMenuBehaviorImpl.

Actual outcome

focusNext/focusPrevious should skip disabled paper-items.

Steps to reproduce

Browsers Affected

  • Chrome
  • [?] Firefox
  • [?] Safari 9
  • [?] Safari 8
  • [?] Safari 7
  • [?] Edge
  • [?] IE 11
  • [?] IE 10
@bicknellr
Copy link
Contributor

(partial recap from offline discussion) Here's another PR that's been open on IronSelectableBehavior about supporting a 'disabled' attribute: PolymerElements/iron-selector#107. My main concern with it is that 'disabled' and 'selectable' are different: I think 'disabled' implies what the end user can do, but that it shouldn't prevent the API user from changing the selected state of a 'disabled' item. Maybe the concept of 'disabled' is better handled at the level of IronMenuBehavior? (Or somewhere else higher up than IronSelectableBehavior?)

giltza added a commit to giltza/iron-menu-behavior that referenced this issue Apr 7, 2016
…oes not skip disabled items.

We are looking at the 'disabled' html dom attribute rather then the iron-control-state 'disabled' property for more generic support.
giltza added a commit to giltza/iron-menu-behavior that referenced this issue Apr 17, 2016
…oes not skip disabled items.

We are looking at the 'disabled' html dom attribute rather then the iron-control-state 'disabled' property for more generic support.
bicknellr added a commit that referenced this issue Apr 18, 2016
Fixing #57 Moving focus to next item (in paper-menu) does not skip disabled items.
@bicknellr
Copy link
Contributor

#58 has been merged. This behavior is enabled in v1.1.6 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants