Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Loop in Makefile Dependency Generation #60

Open
jjenkins278 opened this issue Mar 9, 2022 · 0 comments
Open

Infinite Loop in Makefile Dependency Generation #60

jjenkins278 opened this issue Mar 9, 2022 · 0 comments

Comments

@jjenkins278
Copy link

jjenkins278 commented Mar 9, 2022

In runtime/GNUmakefile, dependency generation uses the following sed script to generate dependencies for sources used in tests:

sed 's|[a-zA-Z0-9_-]*\.o|$(TEST_BUILD_DIR)/&|' ./.depend >> ./.depend

See

sed 's|[a-zA-Z0-9_-]*\.o|$(TEST_BUILD_DIR)/&|' ./.depend >> ./.depend
.

The issue with this script is that ./.depend can be written to before the sed script completes, sending the script into an infinite loop. This behavior is being triggered for me in WSL1 Ubuntu 18.04.

I'll follow up with a PR to break the lib and test dependencies in two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant