Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sender::sendMessage() incorrectly sets DataHeader::unscheduledIndexLimit #7

Open
cstlee opened this issue Sep 2, 2020 · 0 comments

Comments

@cstlee
Copy link
Member

cstlee commented Sep 2, 2020

The documentation states that the DataHeader::unscheduledIndexLimit is the number of packets that "will be sent" without a grant. However, Sender::sendMessage() sets this value to be the max number of packets that "might" be sent. This mismatch can lead the Receiver to expect more unscheduled packets than there are packets in the message which in turn may cause RESEND requests for nonexistent packets. The current implementation ignores these "inconsistent" RESEND request with a warning message and thus the issue doesn't result in an application visible error.

The implementation should be fixed so that both the Sender and Receiver use a consistent definition of unscheduledIndexLimit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant