Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to format_check.py to reduce unintended changes #737

Open
IntegratedQuantum opened this issue Oct 3, 2024 · 0 comments
Open
Labels
contributor friendly this issue is limited in scope and/or knowledge of Cubyz internals, good for newcomers refactor shuffle a lot of code around

Comments

@IntegratedQuantum
Copy link
Member

IntegratedQuantum commented Oct 3, 2024

Common sources for unintended changes are empty lines and newlines at the end of the file.
Since some editors seem to require or at least prefer newlines at the end of files, it would make sense to standardize those.
As for empty lines some editors seem to place full indentation there, while others leave them empty.
I would say empty makes more sense, given that it's just simply less bytes, and also the default behavior in VSCode.

I would like to do this once the two big PRs are merged.

@IntegratedQuantum IntegratedQuantum added contributor friendly this issue is limited in scope and/or knowledge of Cubyz internals, good for newcomers refactor shuffle a lot of code around labels Oct 3, 2024
@IntegratedQuantum IntegratedQuantum added this to the Short-Term Goals milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor friendly this issue is limited in scope and/or knowledge of Cubyz internals, good for newcomers refactor shuffle a lot of code around
Projects
None yet
Development

No branches or pull requests

1 participant